Skip to content

Feature/chk fix callback test #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

Feature/chk fix callback test #88

merged 2 commits into from
Jul 21, 2020

Conversation

@chkuang-g
Copy link
Contributor

@chkuang-g chkuang-g commented Jul 17, 2020

Fix the racy callback test which causes test failure on Windows platform
https://github.com/firebase/firebase-cpp-sdk/runs/846731160

@chkuang-g
Fix racy callback test
8ef350a 
ThreadedCallbackValue1Ordered test was designed racy because
RemoveCallback() can be called before the callback to-be-removed
is added.

Change the test so that the to-be-removed callback is added before
removal.
@googlebot
Copy link

googlebot commented Jul 17, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@chkuang-g chkuang-g changed the base branch from master to dev July 17, 2020 05:22
@chkuang-g
Copy link
Contributor Author

chkuang-g commented Jul 17, 2020

@googlebot I fixed it.

@googlebot
Copy link

googlebot commented Jul 17, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vimanyu
Copy link
Contributor

vimanyu commented Jul 20, 2020

I merged Shawn's changes into my local branch and ran the Github workflows twice to test this and I didn't see this error in the 2 runs.

@chkuang-g
Copy link
Contributor Author

chkuang-g commented Jul 20, 2020

I ran 10000 times using msvc framework and did not see any crash :)

@chkuang-g chkuang-g merged commit d5bd5e5 into dev Jul 21, 2020
@chkuang-g chkuang-g deleted the feature/chk-fix-callback-test branch July 21, 2020 18:48
@firebase firebase locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice Awaiting requested review from a-maurice

1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes type: process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chkuang-g @googlebot @vimanyu @jonsimantov